Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
sanity checks: print test failures for analysis even better
Due to parallel work, we both implemented this functionality at the same time. Switch to my implementation, which has the following advantages: - Use some fancy github output labeling to print the entire testlog, which causes it to be a collapsible element in the github UI. - Use --print-errorlogs, which causes the stderr of failing tests (and only that) to be printed by default, something that ninja test already does ;) because it is smart. Sometimes the failures are obvious from there, although not always -- in the case of libuv which prompted this, the error output is part of the TAP stream on stdout, and errorlogs are only printed based on stderr.
- Loading branch information