Fix extract_all_objects for custom targets with VS backend #8211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvainola
force-pushed
the
fix_extract_objects_for_VS_backend
branch
from
36baeda to
6bb946a
Compare
- Changed the object names built from generated sources on VS backend to match filenames used in ninja backend
vvainola
force-pushed
the
fix_extract_objects_for_VS_backend
branch
from
6bb946a to
bc6f05e
Compare
|
How to fix the unity builds? |
|
Would love to see this land - any chance of re-running the lanes so I can see the failure? |
|
There does not seem to be a button for that so it would need a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to match filenames used in ninja backend
fixes #8020