mtest: only build what is needed for the tests #7902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonzini
force-pushed
the
mtest-build-depends-only
branch
from
d51724f to
7fefdf8
Compare
|
This pull request introduces 1 alert when merging 7fefdf8 into 431f0b0 - view on LGTM.com new alerts:
|
bonzini
force-pushed
the
mtest-build-depends-only
branch
2 times, most recently
from
85669c6 to
3aeb3e6
Compare
bonzini
force-pushed
the
mtest-build-depends-only
branch
from
3aeb3e6 to
fce03a7
Compare
|
The failure is weird since it's a SIGSEGV in a test. It shouldn't be affected by this patch. Let's see if it's transient... EDIT: it went away upon rebase. |
bonzini
force-pushed
the
mtest-build-depends-only
branch
2 times, most recently
from
770ec55 to
004b986
Compare
bonzini
force-pushed
the
mtest-build-depends-only
branch
from
004b986 to
9d05b6d
Compare
|
This is great. I have targets that consists of 100s of file and have LTO enabled by default so take a long time build, but are unneeded by UT tests. This would allow to rapidly build tests during a iterative develop work. |
|
ping... |
jpakkane
reviewed
Dec 13, 2020
With the next patch, "meson test" will be using the targets introspection information. Provide helper functions to share bits of code between mintro.py and mtest.py.
It is a usual workflow to fix something and retest to see if it is fixed using a particular test. When tests start to become numerous, it becomes time consuming for "meson test" to relink all of them (and in fact rebuild the whole project) where the user has already specified the tests they want to run, as well as the tests' dependencies. Teach meson to be smart and only build what is needed for the test (or suite) that were specified. Fixes: mesonbuild#7473 Related: mesonbuild#7830
bonzini
force-pushed
the
mtest-build-depends-only
branch
from
9d05b6d to
79e2c52
Compare
wereii
added a commit
to wereii/meson
that referenced
this pull request
Dec 28, 2020
Merged
wereii
reviewed
Dec 28, 2020
jpakkane
pushed a commit
that referenced
this pull request
Dec 28, 2020
|
I think this PR causes this regression: https://gitlab.freedesktop.org/ocrete/libnice/-/jobs/7348274 CC @ocrete |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a usual workflow to fix something and retest to see if it is fixed using a particular test. When tests start to become numerous, it becomes time consuming for "meson test" to relink all of them (and in fact rebuild the whole project) where the user has already specified the tests they want to run, as well as the tests' dependencies.
Teach meson to be smart and only build what is needed for the test (or suite) that were specified.
Fixes: #7473