Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo: Fix crash when enabling feature on dev/build dependencies #13976

Merged
merged 1 commit into from
Dec 3, 2024
Merged

cargo: Fix crash when enabling feature on dev/build dependencies #13976

merged 1 commit into from
Dec 3, 2024

Conversation

xclaesse
Copy link
Member

@xclaesse xclaesse commented Dec 1, 2024

No description provided.

@xclaesse xclaesse mentioned this pull request Dec 1, 2024
Open
@xclaesse xclaesse mentioned this pull request Dec 1, 2024
Closed
dcbaker
dcbaker approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@dcbaker dcbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, otherwise this LGTM. It's a small enough nit I'd be fine if you just did something with it and merged without further review from me

mesonbuild/cargo/interpreter.py Show resolved Hide resolved
@xclaesse xclaesse merged commit 9e4feed into mesonbuild:master Dec 3, 2024
36 of 37 checks passed
@xclaesse xclaesse deleted the cargo-fix-missing-dep branch December 3, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbaker dcbaker dcbaker approved these changes

@jpakkane jpakkane Awaiting requested review from jpakkane jpakkane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xclaesse @dcbaker