compilers/clike: Speedup cross_compute_int #13926
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirbheek
reviewed
Nov 19, 2024
nirbheek
reviewed
Nov 20, 2024
mesonbuild/compilers/mixins/clike.py
Outdated
| #include <stdio.h> | ||
| #include <stdint.h> | ||
| int main(void) {{ int expression = {expanded}; printf("%d", expression); return 0; }}''' | ||
| run = env.coredata.compilers[mesonlib.MachineChoice.BUILD]['c'].run(evaluate_expanded, env) |
There was a problem hiding this comment.
Error cross-compiling the common: 38 alignment test to armhf:
File "/__w/meson/meson/mesonbuild/compilers/mixins/clike.py", line 485, in cross_compute_int
run = env.coredata.compilers[mesonlib.MachineChoice.BUILD]['c'].run(evaluate_expanded, env)
KeyError: 'c'
This also points out another issue: you have to use the build compiler for the same language as the current compiler. Not 'c' unconditionally.
There was a problem hiding this comment.
not only that but I'll also have to check that self.language for the build machine is actually found.
Theoretically I should probably use compilers.detect_compiler_for(env, self.language, MachineChoice.BUILD, False, <subproject>) but I do not have subproject available at this point
sp1ritCS
force-pushed
the
speedup_cross_compute_int
branch
from
ef74545
to
357fc38
Compare
Expand the expression passed into cross_compute_int using the preprocessor first and then try to evaluate the expanded expression using the host machine compiler and test if the result is valid.
sp1ritCS
force-pushed
the
speedup_cross_compute_int
branch
from
357fc38
to
95390c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the expression passed into cross_compute_int using the preprocessor first and then try to evaluate the expanded expression using the host machine compiler and test if the result is valid.
See #13910 for previous discussion