rust: avoid warnings from rust.test

[bonzini]

Any argument from the base target is copied to the test target, but some keyword arguments for libraries are not available in executable. Remove them, and add a unit test that checks for it with --fatal-meson-warnings.

[dcbaker]

One small nit to use a list instead of a tuple, but otherwise this looks good.

[dcbaker]

Thanks, looks good to me!

[eli-schwartz]

Second commit should be a --fixup and squashed, surely?

[bonzini]

Second commit should be a --fixup and squashed, surely?

To be honest, since Dylan used the suggested changes functionality I just did whatever GitHub told me to do. I can push the squashed version tomorrow.

[eli-schwartz]

The "suggested changes" functionality is for suggesting changes, not committing changes. :) Github doesn't allow you to do one without the other, and it's a wretched mess because github is chronically incapable of enabling correct git workflows when using the web UI to synthesize git commits.

Github staff apparently do not believe that there is any valid way to merge a PR other than by "squash all commits into one using a 5,000-line generated commit message consisting of the --oneline description of each commit including 'address feedback' and 'fixup' and 'revert previous attempt' and 'lint'".

[dcbaker]

Yeah, I always take the "suggested commits", commit them, pull them locally, and then just squash them before repushing. I find I get better results with that approach than manually retyping locally.