Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/rust: Replace gcc -m argument with a -f argument #13421

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

dcbaker
Copy link
Member

@dcbaker dcbaker commented Jul 12, 2024

-m arguments aren't portable across architectures. -fipa-pta will hopefully be portable for gcc, but also not implemented by clang.

Fixes: #13417

-m arguments aren't portable across architectures. -fipa-pta will
hopefully be portable for GCC, but also not implemented by clang.

Fixes: mesonbuild#13417
@dcbaker dcbaker requested a review from jpakkane as a code owner July 12, 2024 23:14
Copy link
Collaborator

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. -fipa-pta is a GCC implementation detail and I've had a semi-firm commitment from Clang people to not implement GCC flags as stubs for compat anymore.

@dcbaker dcbaker merged commit 44323ff into mesonbuild:master Jul 15, 2024
31 of 32 checks passed
@dcbaker dcbaker deleted the submit/rust-test-fix-argument branch July 15, 2024 17:23
@eli-schwartz eli-schwartz added this to the 1.5.1 milestone Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust/12 bindgen fails on aarch64
3 participants