detect windows linkers for flang in detect_fortran_compiler #12305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-vetinari
commented
Sep 29, 2023
|
Do you mind squashing the commits? |
Not at all. Are you fine with doing that through the GitHub UI upon merging, or do you need me to do it manually? |
|
Usually we request contributors to do it manually. |
h-vetinari
force-pushed
the
flang_linker
branch
from
ea4bf36 to
bd5e13e
Compare
|
Anything I can do to help move this forward? |
|
I've poked the matrix/irc channel. That is usually the best way to get people to notice you |
|
I just noticed that I inadvertently introduced a bug in the controlflow here - sorry about that. Fix is in #12803 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to use flang on windows, but currently,
detect_fortran_compilerwill only runguess_nix_linker, and therefore never pick up the right linker for windows. Use the same try-except fallback that's used for C/C++ compilers also for flang.Closes #10778
Tested in conda-forge/scipy-feedstock#246