Fix wrong linker env for HDF5 #11937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h5cc expects the variable ```HDF5_CLINKER``` instead of ```HDF5_CCLINKER``` (see https://github.com/HDFGroup/hdf5/blob/develop/bin/h5cc.in#L97). The same way h5fc expects ```HDF5_FLINKER``` (see https://github.com/HDFGroup/hdf5/blob/develop/fortran/src/h5fc.in#L93). The h5c++ does expect ```HDF5_CXXLINKER```, although it was only fixed in august 2021 (see HDFGroup/hdf5#924), before that it was also ```HDF5_CLINKER```.
tristan957
approved these changes
Jul 3, 2023
|
Why close this? |
|
Sorry, I didn't know the PR will be deleted when I removed the repo. But I'll redo it at some point, I want to do something about #11925 anyway |
|
Thanks. Definitely would like to get this fix in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h5cc expects the variable
HDF5_CLINKERinstead ofHDF5_CCLINKER(see https://github.com/HDFGroup/hdf5/blob/develop/bin/h5cc.in#L97). The same way h5fc expectsHDF5_FLINKER(see https://github.com/HDFGroup/hdf5/blob/develop/fortran/src/h5fc.in#L93). The h5c++ does expectHDF5_CXXLINKER, although it was only fixed in august 2021 (see HDFGroup/hdf5#924), before that it was alsoHDF5_CLINKER.