-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directory within subproject cannot share name with subprojects dir #13774
Comments
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this issue
Oct 10, 2024
This is needed to avoid this mesonbuild/meson#13774 when we go back to making our subproject directory `src`.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this issue
Oct 10, 2024
We got rid of this in c7ec336 because of bug mesonbuild/meson#13774, but in the previous commit we renamed the manual source directory, which avoids it. Now we can change it back.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this issue
Oct 14, 2024
This is needed to avoid this mesonbuild/meson#13774 when we go back to making our subproject directory `src`.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this issue
Oct 14, 2024
We got rid of this in c7ec336 because of bug mesonbuild/meson#13774, but in the previous commit we renamed the manual source directory, which avoids it. Now we can change it back.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this issue
Oct 16, 2024
This is needed to avoid this mesonbuild/meson#13774 when we go back to making our subproject directory `src`. (cherry picked from commit eb7d778)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Suppose my subprojects dir is
foo
Suppose one of my subprojects has a dir called
foo
, e.g. I have something likefoo/subproject-a/bar/foo
This should be fine, but it isn't because this code
meson/mesonbuild/interpreter/interpreter.py
Lines 3139 to 3140 in 7396839
just looks for any directory name in the path matching the subproject dir name
To Reproduce
We were getting this with Nix, but I have not yet minimized it.
Expected behavior
We should not get confused by names, the sandboxing check should allow this.
system parameters
meson --version
ninja --version
if it's a Ninja buildThe text was updated successfully, but these errors were encountered: