Skip to content

Commit

Permalink
vala: don't build .h, .vala, and .gir if export_dynamic is False
Browse files Browse the repository at this point in the history
The current check results in *any* value to `export_dynamic` generating
vala import targets, even `false`. This is pretty clearly wrong, as it
really wants to treat an unset export_dynamic as false.
  • Loading branch information
dcbaker authored and nirbheek committed Feb 18, 2023
1 parent 1b4bc96 commit a92e2b1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mesonbuild/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -1073,7 +1073,7 @@ def process_kwargs(self, kwargs):
self.add_pch('c', extract_as_list(kwargs, 'c_pch'))
self.add_pch('cpp', extract_as_list(kwargs, 'cpp_pch'))

if not isinstance(self, Executable) or 'export_dynamic' in kwargs:
if not isinstance(self, Executable) or kwargs.get('export_dynamic', False):
self.vala_header = kwargs.get('vala_header', self.name + '.h')
self.vala_vapi = kwargs.get('vala_vapi', self.name + '.vapi')
self.vala_gir = kwargs.get('vala_gir', None)
Expand Down

0 comments on commit a92e2b1

Please sign in to comment.