Add custom blur level #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qw3ry
reviewed
Jan 5, 2018
lock
Outdated
| @@ -44,7 +47,7 @@ options="Options: | |||
| # move pipefail down as for some reason "convert -list font" returns 1 | |||
| set -o pipefail | |||
| trap 'rm -f "$image"' EXIT | |||
| temp="$(getopt -o :hdnpglt:f: -l desktop,help,listfonts,nofork,pixelate,greyscale,text:,font: --name "$0" -- "$@")" | |||
| temp="$(getopt -o :hdnpglt:fb: -l desktop,help,listfonts,nofork,pixelate,greyscale,text:,font,blur: --name "$0" -- "$@")" | |||
There was a problem hiding this comment.
one actually needs font: because font has a required parameter.
There was a problem hiding this comment.
Right, fixed it. Thanks for the notice.
|
The script originally had the option for a custom blur level, but if certain blur levels are used it becomes incredibly slow so after a lot of testing one was chosen that was blurred but still fast. If you could update this to the latest master I could pull the option in. Maybe a warning in the help can be added. People with very large monitors could see significant delays in image processing times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all thanks for this project. It looks awesome.
This adds an argument that allows setting a custom level of bluriness.
Here's a screenshot how
i3lock-fancy -b 5.0looks like:And one using 1.5 (the previous value and current default) for comparison:
