No focus on new messages if auto-carousel is off #5881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebentern
reviewed
Jan 20, 2025
|
I still need to build and test it on the node, but something like this should work fine, hopefully. |
thebentern
approved these changes
Jan 20, 2025
|
I suspect that the raspbian checks are broken... Queued for almost 5 hours... |
|
This messes up all standalone nodes that rely on the message screen to know there was a message received like the Tdeck. Before when a message was received it would turn the screen on and focus on the message screen, now I have to manually cycle to see and guess if I receive a message. This need to be rethought |
thebentern
added a commit
that referenced
this pull request
Jan 25, 2025
This reverts commit 0f98115.
thebentern
added a commit
that referenced
this pull request
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often, I need to monitor a specific screen on my node, so I disable the auto-screen carousel. However, every time a new message arrives, it gets focused, forcing me to cycle back manually. To avoid this, I implemented a check: if the carousel is disabled, it no longer focuses on new messages.