Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coerce minimum telemetry interval of 30 minutes on defaults and make new default interval one hour #5086

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

thebentern
Copy link
Contributor

Starting to see Telemetry traffic quickly become the predominant generator of traffic on the public mesh. This is another attempt to back some of that off to make more headroom for text messaging, node discovery, and position updates, as well as prevent inadvertent setting of these values to spammy intervals. I don't need to see everybody's battery level updated every 5 minutes. ;-)

The new standard would be:

  1. No more frequent than 30-minute broadcasts of any telemetry on the default channel
  2. New default of one-hour (up from 30 minutes) for regular interval broadcasts of telemetry.

@andrekir
Copy link
Member

something to consider in the future is coalescing the Telemetry oneOfs into a single broadcast. the 16 byte header makes splitting up in separate small packets very inneficient.

Copy link
Member

@GUVWAF GUVWAF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe after this we should consider changing the "online" status of nodes in the Android/iOS app from 15 min. to 2 hours, which is what the firmware uses. DeviceTelemetry might be the only packet that keeps a node "online", so it means they will switch between online and offline all the time now.

@andrekir
Copy link
Member

good point! both Android and iOS are using 2 hours for online nodes, so we're all set there.

@GUVWAF
Copy link
Member

GUVWAF commented Oct 17, 2024

@andrekir
Copy link
Member

@GUVWAF NodeInfo is now exclusive to the API and was replaced with NodeEntity.

@thebentern thebentern merged commit ec9e562 into master Oct 17, 2024
48 checks passed
panaceya added a commit to mesh-mk-ua/meshtastic-firmware that referenced this pull request Oct 18, 2024
* Coerce minimum telemetry interval of 30 minutes on defaults and make new default interval one hour (meshtastic#5086)

* Coerce minimum telemetry interval of 30 minutes on defaults and make new default interval one hour

* Smaller log messages

* Add buzzer feedback on GPS toggle (meshtastic#5090)

Triple Press on buttons toggles GPS enable/disable.

This enhancement plays a triple-beep so that users of devices with buzzers can get audible feedback about whether they have turned the GPS off or on. This is especially valuable for screenless devices such as the T1000E where it may not be immediately obvious the GPS has been disabled.

---------

Co-authored-by: Ben Meadors <[email protected]>
Co-authored-by: Technologyman00 <[email protected]>
panaceya added a commit to mesh-mk-ua/meshtastic-firmware that referenced this pull request Oct 18, 2024
* Coerce minimum telemetry interval of 30 minutes on defaults and make new default interval one hour (meshtastic#5086)

* Coerce minimum telemetry interval of 30 minutes on defaults and make new default interval one hour

* Smaller log messages

* Add buzzer feedback on GPS toggle (meshtastic#5090)

Triple Press on buttons toggles GPS enable/disable.

This enhancement plays a triple-beep so that users of devices with buzzers can get audible feedback about whether they have turned the GPS off or on. This is especially valuable for screenless devices such as the T1000E where it may not be immediately obvious the GPS has been disabled.

---------

Co-authored-by: Ben Meadors <[email protected]>
Co-authored-by: Technologyman00 <[email protected]>
@thebentern thebentern deleted the enforce-default-telemetry-min branch October 18, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants