Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Board] DIY "t-energy-s3_e22" #4782

Merged
merged 3 commits into from
Sep 22, 2024

Conversation

vidplace7
Copy link
Contributor

New variant t-energy-s3_e22

PXL_20240919_012141649
PXL_20240910_235624521

See also: #4781

@vidplace7 vidplace7 changed the title New variant "t-energy-s3_e22" [Board] New variant "t-energy-s3_e22" Sep 19, 2024
@vidplace7
Copy link
Contributor Author

vidplace7 commented Sep 19, 2024

For now this is using the EBYTE_ESP32_S3 HardwareModel. Doubt this really needs a new protobuf entry.

@vidplace7 vidplace7 changed the title [Board] New variant "t-energy-s3_e22" [Board] DIY "t-energy-s3_e22" Sep 19, 2024
Copy link
Member

@caveman99 caveman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to the assessment regarding the hardware enum. Please use existing enums for DIY boards.

@caveman99
Copy link
Member

Please run your code through 'trunk fmt'

vidplace7 and others added 3 commits September 22, 2024 13:38
- Lilygo T-Energy-S3
- NanoVHF "Mesh-v1.06-TTGO-T18" board
- Ebyte E22 Series
@fifieldt fifieldt merged commit 2ff0af5 into meshtastic:master Sep 22, 2024
107 checks passed
mverch67 pushed a commit that referenced this pull request Sep 23, 2024
* New variant "t-energy-s3_e22"

- Lilygo T-Energy-S3
- NanoVHF "Mesh-v1.06-TTGO-T18" board
- Ebyte E22 Series

* add board_level = extra

* Update variant.h

---------

Co-authored-by: Thomas Göttgens <[email protected]>
Co-authored-by: Tom Fifield <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants