Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore (from)Net time on positions with an unknown or fixed location source #4593

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

thebentern
Copy link
Contributor

@thebentern thebentern commented Aug 30, 2024

Idea here for location sourcing is:

  1. Clients (phone apps) with quality GPS position packets set location source of EXTERNAL
  2. GPS.cpp sets its position with location source of INTERNAL
  3. A node with fixed_position set gets alloc'd as location source of MANUAL

When considering a position packet as a potential time source of RTCQualityFromNet, the firmware will then ignore any position with a location source of UNKNOWN or MANUAL.

@thebentern thebentern merged commit 33eb073 into master Aug 31, 2024
103 checks passed
@thebentern thebentern deleted the location-source-guards branch September 11, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants