Don't send potentially bogus timestamps with fixed location #4001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebentern
approved these changes
May 31, 2024
|
@thebentern this will result in no time source availability in a mesh where no GPS nodes are present. I would suggest to still allow NTP otherwise this is a pretty drastic change. |
wnagele
added a commit
to wnagele/meshtastic-firmware
that referenced
this pull request
Jun 10, 2024
|
Yes, I think NTP quality is probably a good compromise of allowing time source injections while avoiding poor quality times. Care to make a PR?
|
wnagele
added a commit
to wnagele/meshtastic-firmware
that referenced
this pull request
Jun 10, 2024
|
Here you go: #4068 |
wnagele
added a commit
to wnagele/meshtastic-firmware
that referenced
this pull request
Jun 10, 2024
wnagele
added a commit
to wnagele/meshtastic-firmware
that referenced
this pull request
Jun 10, 2024
thebentern
pushed a commit
that referenced
this pull request
Jun 10, 2024
slash-bit
pushed a commit
to slash-bit/meshtastic-echo-echo
that referenced
this pull request
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm seeing a situation where a "rogue" node thinks it has a valid timestamp, but doesn't. It's using fixed position, so the wrong timestamp is overwriting a time provided by another node that actually has a GPS.