-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update fields to retrieve HostID and name #332
Conversation
Signed-off-by: Freedisch <[email protected]>
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Freedisch code in terms of solving issue is good but linting must be added
Signed-off-by: Freedisch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Freedisch Have you verified your changes? Do you get HostID, HostName, DisplayHostName
when you query for model?
You also need to modify GetModel IMO.
@MUzairS15 , I already modified GetModel it's in another in this PR #8257, Regarding the model, are the available models registered under a host/or registrant? |
This is what I was referring to, the second screenshot, hostname and id are empty, you need to modify getmodels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Freedisch I understand that you are retrieving registrants and assigning host details (in your meshery PR), but host details are now included in Model constructs so why not set host details while retrieving models? https://github.com/meshery/meshkit/pull/332/files#diff-69b1a3b3507297713ffe3c635a25bbf8a8807b7a2c316a8bed048c222fde7b55R194
I actually noticed that and updated it, I will fix the conflicts and push it for reviews |
merge conflict |
Signed-off-by: Mohammed Zaki <[email protected]>
Signed-off-by: MUzairS15 <[email protected]>
…filters Signed-off-by: Abhishek kr <[email protected]>
Signed-off-by: Abhishek kr <[email protected]>
Signed-off-by: MUzairS15 <[email protected]>
…filters Signed-off-by: Abhishek kr <[email protected]>
Signed-off-by: Abhishek kr <[email protected]>
Signed-off-by: yash sharma <[email protected]>
Signed-off-by: harkiratsm <[email protected]>
Signed-off-by: Thibaut F. BATALE <[email protected]>
Signed-off-by: Freedisch <[email protected]>
Signed-off-by: Freedisch <[email protected]>
Signed-off-by: Freedisch <[email protected]>
Signed-off-by: Freedisch <[email protected]>
Signed-off-by: Freedisch <[email protected]>
Signed-off-by: Freedisch <[email protected]>
@MUzairS15, thoughts? i updated the pr PS: Refer to this one #337 |
Rady for re-review, @MUzairS15 |
@leecalcote, sorry forgot to close this one. The changes here have been already merged here #337 |
Description
This PR fixes Update fields for Models, Relationships, and components to display host Id and name
Notes for Reviewers
Signed commits