Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calling of ErrFetch and ErrDelete, ErrFetch and ErrPost definition #12609

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weilirs
Copy link

@weilirs weilirs commented Nov 8, 2024

Notes for Reviewers

  • This issue has been stale for 3 weeks
  • I fixed some callings of ErrFetch and ErrDelete to avoid binary in the log.
  • I added Probable Causes and Suggested Remediations to ErrFetch and ErrPosts' definitions.
  • The Log2) in the issue seems to have complete Probable Causes and Suggested Remediations.
  • This PR fixes [Server] Improve Error Code and replace/remove illegible output #12438

Signed commits

  • Yes, I signed my commits.

Copy link

welcome bot commented Nov 8, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

Copy link

github-actions bot commented Nov 8, 2024

Copy link

github-actions bot commented Nov 9, 2024

END-TO-END TESTS

  • Testing started at: November 9th 2024, 1:35:20 am

📦 Test Result Summary

  • ✅ 15 passed
  • ❌ 7 failed
  • ⚠️ 12 flaked
  • ⏩ 0 skipped

Duration: 4 minutes and 34 seconds

Overall Result: 👎 Some tests failed.

[Show/Hide] Test Result Details
Test Browser Test Case Tags Result
1 chromium Add a cluster connection by uploading kubeconfig file unstable ⚠️
2 chromium Transition to disconnected state and then back to connected state unstable ⚠️
3 chromium Transition to ignored state and then back to connected state unstable ⚠️
4 chromium Transition to not found state and then back to connected state unstable ⚠️
5 chromium Delete Kubernetes cluster connections unstable ⚠️
6 chromium Toggle "Send Anonymous Usage Statistics" unstable ⚠️
7 chromium Toggle "Send Anonymous Performance Results" unstable ⚠️
8 firefox Verify that UI components are displayed
9 firefox Add a cluster connection by uploading kubeconfig file unstable ⚠️
10 firefox Transition to disconnected state and then back to connected state unstable ⚠️
11 firefox Transition to ignored state and then back to connected state unstable ⚠️
12 firefox Transition to not found state and then back to connected state unstable ⚠️
13 firefox Delete Kubernetes cluster connections unstable ⚠️
14 firefox Aggregation Charts are displayed
15 firefox Test if Left Navigation Panel is displayed
16 firefox Test if Settings button is displayed
17 firefox Test if Notification button is displayed
18 firefox Test if Profile button is displayed
19 firefox Configure Existing Istio adapter through Mesh Adapter URL from Management page unstable ⚠️
20 firefox Ping Istio Adapter unstable ⚠️
21 firefox Add performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
22 firefox View detailed result of a performance profile (Graph Visualiser) with load generator "fortio" and service mesh "None" unstable ⚠️
23 firefox Edit the configuration of a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
24 firefox Compare test of a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
25 firefox Delete a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
26 firefox Connect to Meshery Istio Adapter and configure it
27 firefox Toggle "Send Anonymous Usage Statistics" unstable ⚠️
28 firefox Toggle "Send Anonymous Performance Results" unstable ⚠️

@leecalcote
Copy link
Member

@Divyansh200102 do you mind offering review on this PR?

@vishalvivekm
Copy link
Member

@weilirs
Let's discuss this during the Meshery Development call today at 9:00 AM CT | 8:30 PM IST. Adding it as an agenda item to the meeting minutes || meeting link.

@weilirs
Copy link
Author

weilirs commented Nov 14, 2024

@weilirs Let's discuss this during the Meshery Development call today at 9:00 AM CT | 8:30 PM IST. Adding it as an agenda item to the meeting minutes || meeting link.

Sorry I missed this message and didn't join. But I believe the modifications I made are stated in the "Notes for Reviewers".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Server] Improve Error Code and replace/remove illegible output
3 participants