-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: calling of ErrFetch and ErrDelete, ErrFetch and ErrPost definition #12609
base: master
Are you sure you want to change the base?
Conversation
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack. |
View in catalog, Edit in playground or learn how to interpret Meshery Designs |
…on Signed-off-by: Lawrence Li <[email protected] Signed-off-by: weilirs <[email protected]>
END-TO-END TESTS
📦 Test Result Summary
⌛ Duration: 4 minutes and 34 seconds Overall Result: 👎 Some tests failed. [Show/Hide] Test Result Details
|
@Divyansh200102 do you mind offering review on this PR? |
@weilirs |
Sorry I missed this message and didn't join. But I believe the modifications I made are stated in the "Notes for Reviewers". |
Notes for Reviewers
ErrFetch
andErrDelete
to avoid binary in the log.ErrFetch
andErrPost
s' definitions.Signed commits