Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating k8s.gcr.io to registry.k8s.io #1029

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

RishabhKodes
Copy link

@RishabhKodes RishabhKodes commented Feb 17, 2023

Description

This PR is a part of the Umbrella issue, kubernetes/k8s.io#4780

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Rishabh Bhandari <[email protected]>
@welcome
Copy link

welcome bot commented Feb 17, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Meshery Contributors' Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@netlify
Copy link

netlify bot commented Feb 17, 2023

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 325ddfb
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/63ef20488d61c20008e4ee20
😎 Deploy Preview https://deploy-preview-1029--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@RishabhKodes
Copy link
Author

RishabhKodes commented Feb 22, 2023

@Chadha93 this PR needs review. (not sure who to tag so tagging you here) PTAL

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, @RishabhKodes 👏

@leecalcote
Copy link
Member

@RishabhKodes will you have a look at the other Meshery repos and seek out an other areas in need of update?

@RishabhKodes
Copy link
Author

RishabhKodes commented Mar 11, 2023

@RishabhKodes will you have a look at the other Meshery repos and seek out an other areas in need of update?

Yeah, I can do that but might be slow in updating all the repositories.

@leecalcote leecalcote merged commit 5470eaf into meshery:master Mar 11, 2023
@welcome
Copy link

welcome bot commented Mar 11, 2023

Thanks for your contribution to the Layer5 and Meshery community! 🎉

Congrats!
        ⭐ Please leave a star on the project. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants