Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Converting Hamburger icon to cross in Navbar after clicking #1894

Open
upsaurav12 opened this issue Sep 5, 2024 · 21 comments
Open

Feat: Converting Hamburger icon to cross in Navbar after clicking #1894

upsaurav12 opened this issue Sep 5, 2024 · 21 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/bug Something isn't working language/css

Comments

@upsaurav12
Copy link

Description

Navbar in smaller width has toggle button but i want to convert that icon(Hamburger) to Cross after clicking to toggle button

Expected Behavior

It should be converted to cross

Screenshots

image

Environment:

  • OS: Mac Linux Windows
  • Browser: Chrome Safari Firefox
  • Version:
  • Device: Desktop Mobile

Contributor Guides and Handbook

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

@upsaurav12 upsaurav12 added the kind/bug Something isn't working label Sep 5, 2024
Copy link

welcome bot commented Sep 5, 2024

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.

@upsaurav12
Copy link
Author

@Ashparshp I have opened the issue

@Ashparshp
Copy link

@upsaurav12, are you working on this issue? If not, we can open it up for new contributors to work on.

@upsaurav12
Copy link
Author

I think it should be open for new contributor. @Ashparshp

@Ashparshp Ashparshp added help wanted Extra attention is needed good first issue Good for newcomers language/css labels Sep 6, 2024
@anniepauline
Copy link

Wanna work on it

@Ashparshp
Copy link

Thank you, @anniepauline! Issue assigned to you. Go ahead! 🚀

@aliciacilmora
Copy link

Wanna work on it

@upsaurav12
Copy link
Author

Thank you, @anniepauline! Issue assigned to you. Go ahead! 🚀

Thanks @Ashparshp

@upsaurav12
Copy link
Author

Wanna work on it

This issue was already assigned to someone you can try on other issues out there .

@Ashparshp
Copy link

@anniepauline, any luck?

@Ashparshp
Copy link

@anniepauline, still working on it?

@GuraaseesSingh
Copy link
Contributor

@Ashparshp Is the contributor still working on the assigned issue. If not, I’d be happy to fix it.

@Ashparshp
Copy link

@GuraaseesSingh, thanks please go ahead..

@GuraaseesSingh
Copy link
Contributor

@Ashparshp Perfect, I will go ahead and update you timely.
Thank you

@upsaurav12
Copy link
Author

When i was working on this issue it was not reflecting the changes that i am making.

Copy link

stale bot commented Nov 10, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Nov 10, 2024
@upsaurav12
Copy link
Author

Hi @Ashparshp can i take this issue ?

@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Nov 10, 2024
@GuraaseesSingh
Copy link
Contributor

Would do a pr by tomorrow.

@soumyamakkar
Copy link

is anyone woking on this issue? if not, can I be assigned?

@upsaurav12
Copy link
Author

@Ashparshp @GuraaseesSingh

@GuraaseesSingh
Copy link
Contributor

GuraaseesSingh commented Dec 20, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/bug Something isn't working language/css
Projects
None yet
Development

No branches or pull requests

6 participants