Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meshmodel support #339

Merged
merged 5 commits into from
Dec 26, 2022
Merged

Conversation

gr455
Copy link
Member

@gr455 gr455 commented Dec 4, 2022

Description

This PR fixes #

Notes for Reviewers
Apart from v1.0.2, all other versions' component generation fails with

INFO[2022-12-04T14:02:56+05:30] Registering for consul.hashicorp.com_exportedservices.yaml  app=consul-adapter
ERRO[2022-12-04T14:02:57+05:30]                                               app=consul-adapter code=1013 probable-cause="Invalid Path or version passed in static configuration.URL passed maybe incorrect.Version passed maybe incorrect" severity=2 short-description="error creating components" suggested-remediation="Make sure to pass correct configuration.Make sure the URL passed in the configuration is correct.Make sure a valid version is passed in configuration"

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Ruturaj Mohite <[email protected]>
Signed-off-by: Ruturaj Mohite <[email protected]>
@welcome
Copy link

welcome bot commented Dec 4, 2022

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Signed-off-by: Ruturaj Mohite <[email protected]>
Signed-off-by: Ashish Tiwari <[email protected]>
Signed-off-by: Ashish Tiwari <[email protected]>
@Revolyssup Revolyssup merged commit 36fce1c into meshery:master Dec 26, 2022
@welcome
Copy link

welcome bot commented Dec 26, 2022

Thanks for your contribution to the Layer5 community! 🎉

Congrats!
        Join the community, if you haven't yet and please leave a ⭐ star on the project. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants