-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add statically generated pattern components for Consul #202
Conversation
Signed-off-by: Rudraksh Pareek <[email protected]>
Signed-off-by: Rudraksh Pareek <[email protected]>
Do we have a workflow in this repo to build components? @Revolyssup |
Hey @DelusionalOptimist I think you haven't attached the github workflow to generate this component. The update-oam-defs.yml one. |
Oops sorry my bad Shreyas have already done that. |
Thank you for pointing this out @sayantan1413 @leecalcote. I'll update either of the PRs with a workflow 👍 |
@Revolyssup I tried using the static components with this updated Docker image to check if they were getting registered. They were not.
Please look into this. |
Signed-off-by: Rudraksh Pareek <[email protected]>
The error is from dynamic component registration and yes thats not working rn because that requires one of the functions which was to be moved to meshkit(the gitwalker function) Although static components are being registered with no problem |
Signed-off-by: leecalcote <[email protected]>
Upgrade to MeshKit v0.2.31 and golang v1.16. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big lift here!
Thanks for your contribution to the Layer5 community! 🎉
|
Signed-off-by: Rudraksh Pareek [email protected]
Description
This PR fixes #
Notes for Reviewers
Generated using much frowned upon and delusionally optimistic methods https://gist.github.com/DelusionalOptimist/7e870dc17bf80277b48cd840aaa0ca9d
Signed commits