-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pattern components generator workflow #199
Add pattern components generator workflow #199
Conversation
Signed-off-by: Shreyas220 <[email protected]>
Signed-off-by: Shreyas220 <[email protected]>
Signed-off-by: Shreyas220 <[email protected]>
Signed-off-by: Shreyas220 <[email protected]>
Signed-off-by: Shreyas220 <[email protected]>
Signed-off-by: Shreyas220 <[email protected]>
Signed-off-by: Shreyas220 <[email protected]>
Signed-off-by: Shreyas220 <[email protected]>
@DelusionalOptimist not able to create a template folder in the master branch |
Signed-off-by: Shreyas220 <[email protected]>
Signed-off-by: Shreyas220 <[email protected]>
353894b
to
b12e6dc
Compare
@Shreyas220 prolly happening because the git auto commit action won't add untracked files/directories for you unless explicitly stated. A templates directory exists now in the master. Please sync and retry. |
Signed-off-by: Shreyas220 <[email protected]>
…into add-aom-workflow
Success, @Shreyas220 ? |
no for some reason I am not able to create the directory, I'll try to resolve the issue and get it merged soon |
Signed-off-by: Rudraksh Pareek <[email protected]>
Signed-off-by: Rudraksh Pareek <[email protected]>
Check the components out here: DelusionalOptimist@2fe6e49 |
This one is a little different from others because consul uses different repos for storing helm charts (crds) and source code (for service mesh releases). Also, multiple helm chart releases reference same consul version. |
@DelusionalOptimist good to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for your contribution to the Layer5 community! 🎉
|
Thank you, @Shreyas220 @Shreyas220. Ready for a new release. 👍 |
Description
This PR fixes #178
workflow to Generate JSON Schema and Definitions for CONSUL components
Signed commits