Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pattern components generator workflow #199

Merged
merged 15 commits into from
Oct 19, 2021

Conversation

Shreyas220
Copy link
Member

Description

This PR fixes #178

workflow to Generate JSON Schema and Definitions for CONSUL components

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Shreyas220 <[email protected]>
Signed-off-by: Shreyas220 <[email protected]>
Signed-off-by: Shreyas220 <[email protected]>
Signed-off-by: Shreyas220 <[email protected]>
Signed-off-by: Shreyas220 <[email protected]>
Signed-off-by: Shreyas220 <[email protected]>
Signed-off-by: Shreyas220 <[email protected]>
Signed-off-by: Shreyas220 <[email protected]>
@Shreyas220
Copy link
Member Author

@DelusionalOptimist not able to create a template folder in the master branch

Signed-off-by: Shreyas220 <[email protected]>
Signed-off-by: Shreyas220 <[email protected]>
@DelusionalOptimist
Copy link
Contributor

@DelusionalOptimist not able to create a template folder in the master branch

@Shreyas220 prolly happening because the git auto commit action won't add untracked files/directories for you unless explicitly stated. A templates directory exists now in the master. Please sync and retry.

@DelusionalOptimist DelusionalOptimist changed the title Add aom workflow Add pattern components generator workflow Oct 5, 2021
@leecalcote
Copy link
Member

Success, @Shreyas220 ?

@Shreyas220
Copy link
Member Author

Success, @Shreyas220 ?

no for some reason I am not able to create the directory, I'll try to resolve the issue and get it merged soon

@DelusionalOptimist DelusionalOptimist self-assigned this Oct 8, 2021
Signed-off-by: Rudraksh Pareek <[email protected]>
Signed-off-by: Rudraksh Pareek <[email protected]>
@DelusionalOptimist
Copy link
Contributor

Check the components out here: DelusionalOptimist@2fe6e49

@DelusionalOptimist
Copy link
Contributor

This one is a little different from others because consul uses different repos for storing helm charts (crds) and source code (for service mesh releases). Also, multiple helm chart releases reference same consul version.

@leecalcote
Copy link
Member

@DelusionalOptimist good to merge?

Copy link
Contributor

@DelusionalOptimist DelusionalOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DelusionalOptimist DelusionalOptimist merged commit 62dcc33 into meshery:master Oct 19, 2021
@welcome
Copy link

welcome bot commented Oct 19, 2021

Thanks for your contribution to the Layer5 community! 🎉

Congrats!
        Join the community, if you haven't yet and please leave a ⭐ star on the project. 😄

@leecalcote
Copy link
Member

Thank you, @Shreyas220 @Shreyas220. Ready for a new release. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Patterns: Generate JSON Schema and Definitions for CONSUL components
3 participants