minor tweaks to support headless testing #88
Conversation
|
Related to RobotLocomotion/drake#13038. |
1) Allows one to optionally pass a renderer to the Viewer constructor 2) Count the number of messages received 3) Use window.CCapture instead of CCapture, as recommended in https://stackoverflow.com/questions/48864251/how-to-run-ccapture-by-server-side-node-js (and it still works in the normal browser)
| this.renderer.shadowMap.type = THREE.PCFSoftShadowMap; | ||
| this.dom_element.appendChild(this.renderer.domElement); | ||
| } else { | ||
| this.renderer = renderer; |
There was a problem hiding this comment.
If it's possible, asserting renderer is the right type here might prevent really confusing deferred errors later if someone shoves in a bad renderer type (e.g. accidentally invokes the constructor with a weird extra argument)?
There was a problem hiding this comment.
That's a good point, although I don't actually know what the right assertion would be, since javascript typing is kind of the wild west. I'm ok with leaving this open-ended for now.
|
By the way, I stalled on updating the |
https://stackoverflow.com/questions/48864251/how-to-run-ccapture-by-server-side-node-js
(and it still works in the normal browser)