Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firedrake ValueError raised on transfer #110

Closed
acse-ej321 opened this issue Feb 15, 2024 · 1 comment · Fixed by #113
Closed

Firedrake ValueError raised on transfer #110

acse-ej321 opened this issue Feb 15, 2024 · 1 comment · Fixed by #113
Assignees
@jwallwork23
Labels
bug Something isn't working question Further information is requested
Milestone
Version 1

Comments

@acse-ej321
Copy link
Collaborator

https://github.com/pyroteus/goalie/blob/7ecf95d75064c3c958fc84b2408f1a7c0fb8da42/goalie/go_mesh_seq.py#L169-L172

@jwallwork23 - I am now getting a ValueError raised by Firedrake when applying transfer between the base and enriched meshes: ValueError("Can't map across hierarchies"). I am running the Burger's demo with an isotropic mesh adaptor. I don't encounter this error when running the Point Discharge steady-state demo with the same isotropic mesh adaptor.

I can put together a minimum failure scenario if needed.
@acse-ej321 acse-ej321 added bug Something isn't working question Further information is requested labels Feb 15, 2024
@jwallwork23 jwallwork23 added this to the Version 1 milestone Feb 20, 2024
@jwallwork23
Copy link
Member

Hm okay so something is going wrong in the time-dependent case. If you could provide a MFE that'd be great, thanks.

jwallwork23 added a commit that referenced this issue Feb 28, 2024
@jwallwork23
#110: mesh_seq_e -> enriched_mesh_seq
a66197f
jwallwork23 added a commit that referenced this issue Feb 28, 2024
@jwallwork23
#110: Fix typo; pull up method
bf8c52f
jwallwork23 added a commit that referenced this issue Feb 28, 2024
@jwallwork23
#110: Raise error on attempting to h-enrich shallow copied meshes
8334e6a
jwallwork23 added a commit that referenced this issue Feb 28, 2024
@jwallwork23
#110: Test for h-enrichment error
feab3bd
@jwallwork23 jwallwork23 mentioned this issue Feb 28, 2024
Merged
@jwallwork23 jwallwork23 self-assigned this Feb 28, 2024
jwallwork23 added a commit that referenced this issue Mar 7, 2024
@jwallwork23
Disallow h-enrichment of shallow-copied meshes (#113)
4cf8dc4 
Closes #110.

This PR stops the user from h-enriching shallow-copied meshes, thereby fixing the bug raised.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwallwork23 jwallwork23

Labels
bug Something isn't working question Further information is requested
Projects
Mesh Adaptation development board
Status: Done
Milestone
Version 1
Development

Successfully merging a pull request may close this issue.

Disallow h-enrichment of shallow-copied meshes mesh-adaptation/goalie
2 participants
@jwallwork23 @acse-ej321