Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjoint transfer tests are incorrect #114

Open
jwallwork23 opened this issue Apr 27, 2024 · 0 comments
Open

Adjoint transfer tests are incorrect #114

jwallwork23 opened this issue Apr 27, 2024 · 0 comments
Labels
bug Something isn't working PRIORITY We should address this ASAP testing Extensions and improvements to the testing infrastructure
Milestone
Version 1

Comments

@jwallwork23
Copy link
Member

If different meshes are used instead of the trivial ones currently used in TestTransfer then we get test failures for the adjoint transfer operators. The tests assert that applying the adjoint transfer to a source should give the same result as a forward transfer, but this is nonsense.
@jwallwork23 jwallwork23 added bug Something isn't working testing Extensions and improvements to the testing infrastructure PRIORITY We should address this ASAP labels Apr 27, 2024
@jwallwork23 jwallwork23 added this to the Version 1 milestone Apr 27, 2024
jwallwork23 added a commit that referenced this issue Apr 27, 2024
@jwallwork23
#114: Skip broken tests
326ce97
@jwallwork23 jwallwork23 mentioned this issue Apr 27, 2024
Merged
jwallwork23 added a commit that referenced this issue May 14, 2024
@jwallwork23
Enable mass lumping for projection operator (#115)
83548dc 
Closes #95.

This PR allows the projection operator (and its adjoint) to be mass
lumped. For P1 spaces, this implies that extrema are preserved following
the transfer.

While developing these changes, I noticed #113 and #114, so the
associated functionality and tests are turned off here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working PRIORITY We should address this ASAP testing Extensions and improvements to the testing infrastructure
Projects
Mesh Adaptation development board
Status: Priority
Milestone
Version 1
Development

No branches or pull requests
1 participant
@jwallwork23