-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use volumesForm in definition file #928
Conversation
We don't change the attribute in the mesg.yml. Services already depend on this attribute there is no strong reason to change it. This is a breaking change that is not necessary and not the time right now for that. |
Everywhere we are using |
We didn't break |
Yes, mesg.yml is not broken for now. Also, I think there is a way to parse the yaml with one attribute or the other something like The breaking changes of the API are not as critical as the mesg.yml, API is mostly internal (or used with other tools we control such as the js library), We don't have any control on the mesg.yml so this is a critical breaking change and just for cosmetic... |
Let's include this change in the future break of the task's output |
TODO:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with a service with a dependency that read and write on 2 shared files 👍
No description provided.