-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Orchestrator gRPC API #1771
Conversation
I had some issues with the validation of the pub key. Here is my
authorized_pubkeys:
- mesgtestpub1pakk3s28ym3pjj443e4g3u3jnch04cuhgjdfqx
account:
mnemonic: >-
guard paddle nature laptop space patient one wait airport side buffalo
ceiling prevent ten planet immune sample duty fox box option know slot bone What am I missing? |
Your pubkey seems truncated. The one I'm using is much longer: |
Move bech32 prefix set in init function to solve issue with validator
Move Register Runner from Runner API to Orchestrator
489b6b7
to
258ff4d
Compare
// TODO: to switch when e2e tests doesn't create any event | ||
// EventClient orchestrator.EventClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will do this in an other PR. Same for https://github.com/mesg-foundation/engine/pull/1771/files#diff-d7befae5ac5d72ce8456da5eae6f2500R117-R118
alreadySeeHashes[attr] = true | ||
hash, err := hash.Decode(attr) | ||
if err != nil { | ||
return err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a good thing to return the error here, shouldn't we have an error channel?
Here the first error will actually stop the whole stream.
Might have the same issue on the runner API which might be more critical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no error channel with gRPC streams. The only way to return the error to the client is to return it as it does.
Related to #1764
This PR adds the Orchestrator API.
This API requires authentication by verifying a base64-encoded signature of the request, set in the request's metadata using the key
mesg_request_signature
.It defines the following RPC functions:
Note: the runner register rpc has been moved from Runner API to this Orchestrator API.