-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cosmos events #1769
Update cosmos events #1769
Conversation
…ler of each module
…tions of each module.
…tion from grpc client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is good, the execution's events could be improved, now the behavior is a bit weird, I would recommend sending an event for every single mutation of the execution so
- x events for proposed
- 1 event for created
- 0 or 1 event for completed
- 0 or 1 event for failed
Based on your table:
key | value |
---|---|
action | proposed OR inProgress (I don't really like in progress could be better created) OR completed OR failed |
hash | execution's hash |
address | execution's address |
status | execution's status |
executor | execution's executor hash |
process | optional execution's process hash |
instance | execution's instance hash |
…so when execution is only proposed.
de67d3f
to
f97bf9e
Compare
Execution event updated to:
|
if alreadySeeHashes[attr] { | ||
continue | ||
} | ||
alreadySeeHashes[attr] = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny issue but maybe this should be done only when everything is ok so after we get the execution, before the Filter.Match
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filter match is based on the date of the execution, so even if it's not the right event, the data of the execution will be the same so the filter will work exactly the same way all the time.
closes #1747
Improved event filtering
The new events allow creating queries that exactly match resources we want.
Instead of having to filter possible matching resources, now you should be able to write queries that match them perfectly.
Example that match execution for a specific executor and status (source):
Events list
message
All modules emit an event type
message
when they received a destined message with the following data:service
mesgtestXXX
create
service
The module service emits an event type
service
when a service has been created with the following data:created
runner
The module runner emits an event type
runner
when a runner has been created or deleted with the following data:created
ORdeleted
process
The module process emits an event type
process
when a process has been created or deleted with the following data:created
ORdeleted
ownership
The module ownership emits an event type
ownership
when an ownership has been created or deleted with the following data:created
ORdeleted
instance
The module instance emits an event type
instance
when an instance has been created with the following data:created
execution
The module execution emits an event type
execution
when an execution has been proposed, created or when a result has been submitted with the following data:proposed
ORcreated
ORcompleted
ORfailed