Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a simple LCD client #1758

Merged
merged 5 commits into from
Mar 28, 2020
Merged

Introduce a simple LCD client #1758

merged 5 commits into from
Mar 28, 2020

Conversation

NicolasMahe
Copy link
Member

Dependent on #1757

  • introduce a simple LCD client
  • use it in the e2e tests

@NicolasMahe NicolasMahe requested a review from antho1404 March 27, 2020 09:43
@NicolasMahe NicolasMahe self-assigned this Mar 27, 2020
@NicolasMahe NicolasMahe added this to the next milestone Mar 27, 2020
@NicolasMahe NicolasMahe added the release:add Pull requests that add something label Mar 27, 2020
@antho1404 antho1404 mentioned this pull request Mar 27, 2020
Merged
9 tasks
antho1404
antho1404 reviewed Mar 28, 2020
View reviewed changes
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do another client in the same package cosmos I think we should as least rename the current client to something less generic than Client and maybe ABCI. Right now we have Client and LCD.

cosmos/lcd.go Outdated Show resolved Hide resolved
@NicolasMahe
Copy link
Member Author

If we do another client in the same package cosmos I think we should as least rename the current client to something less generic than Client and maybe ABCI. Right now we have Client and LCD.

renamed to RPC

@NicolasMahe NicolasMahe merged commit f78ceca into dev Mar 28, 2020
@NicolasMahe NicolasMahe deleted the feature/lcd-client branch March 28, 2020 11:13
@NicolasMahe NicolasMahe mentioned this pull request Apr 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antho1404 antho1404 antho1404 approved these changes

Assignees

@NicolasMahe NicolasMahe

Labels
release:add Pull requests that add something
Projects
None yet
Milestone
v0.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@NicolasMahe @antho1404