Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add address to process #1723

Merged
merged 3 commits into from
Mar 13, 2020
Merged

Add address to process #1723

merged 3 commits into from
Mar 13, 2020

Conversation

antho1404
Copy link
Member

Small PR to add the address format to the process in order to be able to send token to this process.

Few ways this can be improved:

  • In hash#marshalJSON we could return the address instead of the base58
  • We could find a way to calculate this address on the client-side
  • We could replace the hash by the address in the resource

This is a quick fix in order to fix the issue with the executions that collect coin from the process (#1699) but will need to be improved with #1715

@antho1404 antho1404 added the enhancement New feature or request label Mar 12, 2020
@antho1404 antho1404 added this to the next milestone Mar 12, 2020
@antho1404 antho1404 self-assigned this Mar 12, 2020
# Conflicts:
#	e2e/process_test.go
@NicolasMahe NicolasMahe added the release:add Pull requests that add something label Mar 13, 2020
@NicolasMahe NicolasMahe merged commit ccf5ecc into dev Mar 13, 2020
@NicolasMahe NicolasMahe deleted the feature/process-address branch March 13, 2020 11:16
@NicolasMahe NicolasMahe mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release:add Pull requests that add something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants