Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use instance hash in event #1122

Merged
merged 2 commits into from
Jun 26, 2019
Merged

Use instance hash in event #1122

merged 2 commits into from
Jun 26, 2019

Conversation

krhubert
Copy link
Contributor

No description provided.

NicolasMahe
NicolasMahe requested changes Jun 26, 2019
View reviewed changes
event/event.go Outdated Show resolved Hide resolved
@krhubert krhubert force-pushed the fix/event-use-instance-hash branch from 8ec4d19 to 5e72f28 Compare June 26, 2019 07:29
antho1404
antho1404 reviewed Jun 26, 2019
View reviewed changes
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The listenEvent should be updated too to listen to the instance and not the service

@krhubert
Copy link
Contributor Author

This will be done in next PR when event api will be created

@NicolasMahe NicolasMahe merged commit e00cc7a into dev Jun 26, 2019
@NicolasMahe NicolasMahe deleted the fix/event-use-instance-hash branch June 26, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasMahe NicolasMahe NicolasMahe approved these changes

@antho1404 antho1404 antho1404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krhubert @antho1404 @NicolasMahe