Update Github CI workflows for CPU builds and tests

[ohearnk]

This MR updates the QUICK tests in Github workflows to use v4 artifact actions (v1 and v2 deprecated, then removed -- see here).

Additionally, this MR also updates the checkout action (v4), renames the build artifacts to avoid naming conflicts between the two build systems (legacy configure/make, and CMake)., parallelizes the serial builds, switches to invoking the CMake build/install commands directly (instead of depending on the generated Makefiles), and refactoring the general job and step naming to better reflect the tasks.

[agoetz]

The cmake builds fail. The logs show

Run actions/upload-artifact@v4
With the provided path, there will be 169 files uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

From https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes

Breaking Changes

• Uploading to the same named Artifact multiple times.

Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once. Otherwise you will encounter an error.

Fix is not working, tests fail.

[agoetz]

While we are at it, we should update the build command. Gihub hosted runners now have 4 CPU cores. See

https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

We currently use make and make -j2.

We should update to make -j4 or just use make -j, which should automatically build on all available CPU cores.

[ohearnk]

@agoetz Regarding bumping up the number of cores used in Github runners from 2 to 4 -- doing this causes the MPI tests to fail consistently on the first test (both configure/make and CMake builds). Moreover, the error code returned from most of these failed tests from quick.MPI appears to be a value of 2 (i.e., the MPI rank first detected to be aborting).

Can you check if there is a settting in the merzlab account regarding the Github runner configuration? My best guess is that a change might be required to reflect the hardware upgrades.

Other than that issue, this should be ready to merge.

[merzlab]

@ohearnk There are no settings regarding the Github runner configuration. There is an option for Larger Github-hosted runners, but this is restricted to Team & Enterprise accounts. Another option is Self-hosted runners. These are virtual machines for GitHub Actions workflows that you manage and maintain outside of GitHub. We should look into this.

I checked for the CPU in the Github runner:

> Run lscpu
Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Address sizes:                      48 bits physical, 48 bits virtual
Byte Order:                         Little Endian
CPU(s):                             4
On-line CPU(s) list:                0-3
Vendor ID:                          AuthenticAMD
Model name:                         AMD EPYC 7763 64-Core Processor
CPU family:                         25
Model:                              1
Thread(s) per core:                 2
Core(s) per socket:                 2
Socket(s):                          1

The information on the Github website is misleading. These are actually 4 threads but only 2 physical 4 CPU cores.

Let's leave build and MPI runs at 2 cores.

[merzlab]

Looks good. I will merge this PR.