Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function always getting executed for turbine go #803

Merged
merged 1 commit into from
Aug 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cmd/meroxa/turbine/golang/deploy.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ func (t *turbineGoCLI) StartGrpcServer(ctx context.Context, gitSha string) (func
"run",
"./...",
"build",
"-gitsha",
gitSha,
"-gitsha", gitSha,
"-turbine-core-server", grpcListenAddress,
"-app-path", t.appPath,
}...)
Expand Down
1 change: 1 addition & 0 deletions cmd/meroxa/turbine/golang/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ func (t *turbineGoCLI) Run(ctx context.Context) error {
"-gitsha", "devel",
"-turbine-core-server", grpcListenAddress,
"-app-path", t.appPath,
"-run-process",
}...)
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ require (
require (
github.com/briandowns/spinner v1.23.0
github.com/mattn/go-shellwords v1.0.12
github.com/meroxa/turbine-core v0.0.0-20230808162125-33f70f75883e
github.com/meroxa/turbine-core v0.0.0-20230815153536-e0c914b74ea1
github.com/stretchr/testify v1.8.4
github.com/withfig/autocomplete-tools/integrations/cobra v1.2.1
golang.org/x/mod v0.12.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,8 @@ github.com/mattn/go-shellwords v1.0.12 h1:M2zGm7EW6UQJvDeQxo4T51eKPurbeFbe8WtebG
github.com/mattn/go-shellwords v1.0.12/go.mod h1:EZzvwXDESEeg03EKmM+RmDnNOPKG4lLtQsUlTZDWQ8Y=
github.com/meroxa/meroxa-go v0.0.0-20230630181637-7cfd524c070a h1:Kd/d630d6ykAagdSGwc47zVenqYRYILTm7O70NmyFz8=
github.com/meroxa/meroxa-go v0.0.0-20230630181637-7cfd524c070a/go.mod h1:c1rom/GgYA74PAHorffVlOWCaUhMc5DFbAvt1UwD76Y=
github.com/meroxa/turbine-core v0.0.0-20230808162125-33f70f75883e h1:iKQYPOfVZNQLu5JPKmBIS+23yMOXe13MUjDyDWLqmI0=
github.com/meroxa/turbine-core v0.0.0-20230808162125-33f70f75883e/go.mod h1:tKaTgZPdjOIJk9MM0HwOa4QC++DRAxcAmDwIblb6M5U=
github.com/meroxa/turbine-core v0.0.0-20230815153536-e0c914b74ea1 h1:4tx5X9TVepTLVYP2ZOokKwkCSBldtGZh69kArXZaI9c=
github.com/meroxa/turbine-core v0.0.0-20230815153536-e0c914b74ea1/go.mod h1:03beJfCWdChsKHzbhiDlOcYKyAKkrtoC3y8ualUFOrI=
github.com/mitchellh/mapstructure v1.5.0 h1:jeMsZIYE/09sWLaz43PL7Gy6RuMjD2eJVyuac5Z2hdY=
github.com/mitchellh/mapstructure v1.5.0/go.mod h1:bFUtVrKA4DC2yAKiSyO/QUcy7e+RRV2QTWOzhPopBRo=
github.com/nirasan/go-oauth-pkce-code-verifier v0.0.0-20170819232839-0fbfe93532da h1:qiPWuGGr+1GQE6s9NPSK8iggR/6x/V+0snIoOPYsBgc=
Expand Down
2 changes: 1 addition & 1 deletion vendor/modules.txt
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ github.com/mattn/go-shellwords
## explicit; go 1.20
github.com/meroxa/meroxa-go/pkg/meroxa
github.com/meroxa/meroxa-go/pkg/mock
# github.com/meroxa/turbine-core v0.0.0-20230808162125-33f70f75883e
# github.com/meroxa/turbine-core v0.0.0-20230815153536-e0c914b74ea1
## explicit; go 1.20
github.com/meroxa/turbine-core/lib/go/github.com/meroxa/turbine/core
github.com/meroxa/turbine-core/pkg/app
Expand Down
Loading