Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IR] accommodate preIR and IR deployments side by side #433

Merged
merged 11 commits into from
Sep 23, 2022
Merged

[IR] accommodate preIR and IR deployments side by side #433

merged 11 commits into from
Sep 23, 2022

Conversation

janelletavares
Copy link
Contributor

@janelletavares janelletavares commented Sep 6, 2022 •
edited
Loading

Description of change

Fixes https://github.com/meroxa/product/issues/544

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging
  • Tested in minikube

Demo

before after

Additional references

Documentation updated

@janelletavares janelletavares changed the title accommodate preIR and IR deployments side by side [IR] accommodate preIR and IR deployments side by side Sep 21, 2022
@janelletavares janelletavares marked this pull request as ready for review September 21, 2022 23:53
@janelletavares
Copy link
Contributor Author

I tested the pre IR and IR code paths for go apps. Test results pending for py and js.

raulb
raulb reviewed Sep 22, 2022
View reviewed changes
cmd/meroxa/root/apps/deploy.go Show resolved Hide resolved
cmd/meroxa/root/apps/deploy.go Outdated Show resolved Hide resolved
jayjayjpg
jayjayjpg approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great, thank you for putting all of this together so quickly! ✨

@janelletavares janelletavares merged commit 1e7687a into master Sep 23, 2022
@janelletavares janelletavares deleted the ir-fork branch September 23, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyuboxa lyuboxa lyuboxa left review comments

@raulb raulb raulb left review comments

@jayjayjpg jayjayjpg jayjayjpg approved these changes

@dianadoherty dianadoherty Awaiting requested review from dianadoherty

@ericcheatham ericcheatham Awaiting requested review from ericcheatham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@janelletavares @raulb @jayjayjpg @lyuboxa