Ignore capitalization when initializing an app #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayjayjpg
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
any combination of capital letters in the language name should be acceptable
Fixes https://github.com/meroxa/product/issues/541
Type of change
How was this tested?
Demo
BEFORE
$ m apps init --lang GoLang capitalization
x
Error: language "GoLang" not supported. Currently, we support "javascript", "golang", and "python"
AFTER
$ m apps init --lang GoLang capitalization
✔ Application directory created!
✔ go mod init succeeded!
✔ Downloaded latest turbine-go and turbine-go/running dependencies successfully!
✔ Downloaded all other dependencies successfully!
✔ Git initialized successfully!
Turbine Data Application successfully initialized!
You can start interacting with Meroxa in your app located at "/home/janelle/go/src/github.com/meroxa/demos/capitalization".
Your Application will not be visible in the Meroxa Dashboard until after deployment.
Additional references
Documentation updated