Update init command format and add a helpful link #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janelletavares
force-pushed
the
init-enhancements
branch
from
e0f92fc
to
220c6d3
Compare
janelletavares
commented
Jul 13, 2022
| } | ||
|
|
||
| return os.Chdir(pwd) | ||
| } | ||
|
|
||
| func modulesInit(l log.Logger, appPath string, skipInit, vendor bool) error { |
There was a problem hiding this comment.
lint complained... made me do it
janelletavares
force-pushed
the
init-enhancements
branch
from
8d59572
to
3552f0c
Compare
jayjayjpg
approved these changes
Jul 18, 2022
| case "js", JavaScript, NodeJs: | ||
| err = turbinejs.Init(ctx, i.logger, name, i.path) | ||
| case "py", Python3, Python: | ||
| err = turbinepy.Init(ctx, i.logger, name, i.path) | ||
| default: | ||
| i.logger.StopSpinnerWithStatus("\t", log.Failed) |
cmd/meroxa/turbine_cli/utils.go
Outdated
| func GoInit(ctx context.Context, l log.Logger, appPath string, skipInit, vendor bool) error { | ||
| func GoInit(l log.Logger, appPath string, skipInit, vendor bool) error { | ||
| l.StartSpinner("\t", "Running golang module initializing...") | ||
| skipLog := "skipping go module initialization\n\tFor guidance, visit https://docs.meroxa.com/beta-overview#go-mod-init-for-a-new-golang-turbine-data-application" |
| @@ -62,3 +65,7 @@ func (l *spinnerLogger) SuccessfulCheck() string { | |||
| func (l *spinnerLogger) FailedMark() string { | |||
| return color.New(color.FgRed).Sprintf("x") | |||
| } | |||
|
|
|||
| func (l *spinnerLogger) WarningMark() string { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Make init command conform to the standards of the other app commands.
Provide a helpful link when go mod init must be aborted.
Fixes https://github.com/meroxa/turbine-project/issues/202
Fixes https://github.com/meroxa/turbine-project/issues/212
Type of change
How was this tested?
Demo
BEFORE
AFTER
Additional references
Documentation updated