Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always use app name defined in app.json #323

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

raulb
Copy link
Member

@raulb raulb commented Apr 18, 2022

Description of change

Fixes https://github.com/meroxa/turbine-project/issues/173

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

@raulb raulb self-assigned this Apr 18, 2022
@raulb raulb force-pushed the raul/fix-inconsistent-app-name branch from 4bed934 to 7ee126c Compare April 18, 2022 15:07
Copy link
Contributor

@janelletavares janelletavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tested it locally... works great. thanks!

@janelletavares
Copy link
Contributor

oof... my code is warning unnecessarily
warning: failed to clean up app at /home/janelle/go/src/github.com/meroxa/demos/location-test2: remove /home/janelle/go/src/github.com/meroxa/demos/location-test2/location-test*: no such file or directory

@raulb
Copy link
Member Author

raulb commented Apr 18, 2022

oof... my code is warning unnecessarily warning: failed to clean up app at /home/janelle/go/src/github.com/meroxa/demos/location-test2: remove /home/janelle/go/src/github.com/meroxa/demos/location-test2/location-test*: no such file or directory

I'll look into this.

@raulb raulb merged commit 4405f53 into master Apr 18, 2022
@raulb raulb deleted the raul/fix-inconsistent-app-name branch April 18, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants