Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile and binary changes to accommodate vendor or no vendor #320

Merged
merged 6 commits into from
Apr 18, 2022
Merged

Dockerfile and binary changes to accommodate vendor or no vendor #320

merged 6 commits into from
Apr 18, 2022

Conversation

janelletavares
Copy link
Contributor

@janelletavares janelletavares commented Apr 18, 2022 •
edited
Loading

Description of change

Fixes https://github.com/meroxa/turbine-project/issues/171

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging
  • Tested in minikube

Demo

Screenshot from 2022-04-17 18-10-34

Screenshot from 2022-04-17 20-18-26

Additional references

Documentation updated

@janelletavares janelletavares marked this pull request as ready for review April 18, 2022 03:18
@janelletavares janelletavares requested review from a team, simonl2002 and ahmeroxa and removed request for a team April 18, 2022 03:30
raulb
raulb approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 once updated to latest turbine-go

@janelletavares janelletavares merged commit bb837f7 into master Apr 18, 2022
@janelletavares janelletavares deleted the dockerfile-vendor branch April 18, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb approved these changes

@simonl2002 simonl2002 Awaiting requested review from simonl2002 simonl2002 was automatically assigned from meroxa/platform-backend

@ahmeroxa ahmeroxa Awaiting requested review from ahmeroxa ahmeroxa was automatically assigned from meroxa/platform-backend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janelletavares @raulb