Define contract for turbine response and capture #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return processError(err, path, output) | ||
| } | ||
|
|
||
| r, _ := regexp.Compile("\nturbine-response: (true|false)\n") |
There was a problem hiding this comment.
Suggested change
| r, _ := regexp.Compile("\nturbine-response: (true|false)\n") | |
| r := regexp.MustCompile("\nturbine-response: (true|false)\n") |
nit
jmar910
force-pushed
the
james/harden-ouput-capturing
branch
from
a7ef81d
to
488f490
Compare
jmar910
force-pushed
the
james/harden-ouput-capturing
branch
from
488f490
to
1943e97
Compare
jayjayjpg
reviewed
Apr 14, 2022
There was a problem hiding this comment.
This reads great! I took a spin on this locally and noticed that app initialization and runs work great with regards to output and error handling, but something seems amiss with deploying apps -- is this related to this change?
$ ./meroxa apps deploy --path ../demos/myjsapp
Checking for uncommitted changes...
✔ No uncommitted changes!
Validating branch...
✔ Deployment allowed from master branch!
Preparing application "myjsapp" (javascript) for deployment...
✔ Application built!
Error: strconv.ParseBool: parsing "turbine-response: true": invalid syntaxThe recording includes
- a failed deployment of an app instance to the same namespace
myjsapp - another subsequent redeployment to the
myjsappafter deleting the previous app that also fails
|
@jayjayjpg just to confirm, did you pull and build the latest |
|
@jmar910 Yes exactly, but let me double check and record just to make sure, also happy to huddle if it's helpful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
CLI now expects a specific format when receiving responses from turbine-js. This allows us to only capture what we care about and leave the rest of the output alone.
Type of change
How was this tested?
Demo
Additional references
See this thread https://meroxa.slack.com/archives/C02L14X6TA9/p1649879600763529
Blockers