Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatter is unhelpful and makes things difficult to copy & paste #305

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Formatter is unhelpful and makes things difficult to copy & paste #305

merged 1 commit into from
Apr 8, 2022

Conversation

janelletavares
Copy link
Contributor

@janelletavares janelletavares commented Apr 7, 2022 •
edited
Loading

Description of change

Fixes https://github.com/meroxa/turbine-project/issues/144

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging
  • Tested in minikube

Demo

Screenshot from 2022-04-07 19-11-10

Screenshot from 2022-04-07 19-11-48

Additional references

Documentation updated

@janelletavares janelletavares marked this pull request as ready for review April 8, 2022 02:10
raulb
raulb approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder when we added this if it was really relevant. I agree this doesn't seem to be needed

jayjayjpg
jayjayjpg approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great! ✨

@janelletavares janelletavares merged commit 4640356 into master Apr 8, 2022
@janelletavares janelletavares deleted the display-titles branch April 8, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayjayjpg jayjayjpg jayjayjpg approved these changes

@raulb raulb raulb approved these changes

@ericcheatham ericcheatham Awaiting requested review from ericcheatham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janelletavares @raulb @jayjayjpg