Distinguish between regular and extended app describe #298
Conversation
janelletavares
requested review from
a team,
ahmeroxa and
anna-cross
and removed request for
a team
There was a problem hiding this comment.
Yesterday I was chatting with @jayjayjpg about this one, and I was wondering if this information could be returned by the API directly, so we wouldn't need to fetch for each of the resources. Possibly having even two different endpoints such as:
GET /v1/applications/:uuid(no--extended)GET /v1/applications/:uuid?extended(with--extended).
What do you think?
P.S..: This question is not a blocker just an alternative implementation in case the list of connectors / functions / etc... ends up being too big.
the current implementation is quite slow. doing it all in the API would be faster and nicer. i could go either way, but at this point, i would favor making time for python work over another implementation of this; i'd be happy to open a follow up ticket to improve performance/efficiency around this. how does that sound? |
|
@janelletavares Yes, fully agree with you and that sounds good to me! |
|
opened this issue https://github.com/meroxa/turbine-project/issues/129 |
| return output | ||
| } | ||
|
|
||
| func extendedResourcesTable(resources []*meroxa.Resource, connectors map[string]*meroxa.Connector) string { |
There was a problem hiding this comment.
i'm still not sure why, but the typical library used for these tables was giving me lots of issues with nil pointers when trying to format these two subtables, so i just went with a less flexible option
@janelletavares makes sense to me |
Description of change
Fixes https://github.com/meroxa/turbine-project/issues/111
Type of change
How was this tested?
Demo
Additional references
Documentation updated