Validate application names so that API calls and Docker build doesn't… #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janelletavares
requested review from
a team,
hariso and
samirketema
and removed request for
a team
janelletavares
force-pushed
the
validate-app-name
branch
from
d500fca
to
90ab79b
Compare
raulb
requested changes
Apr 1, 2022
Co-authored-by: Raúl Barroso <[email protected]>
you caught me ;-) not stealthy enough |
added 2 commits
April 1, 2022 16:50
raulb
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… fail later
Description of change
Fixes https://github.com/meroxa/turbine-project/issues/108
Type of change
How was this tested?
Demo
Additional references
Documentation updated