Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create the application if it doesn't already exist with the give… #295

Merged
merged 3 commits into from
Apr 4, 2022

Conversation

janelletavares
Copy link
Contributor

@janelletavares janelletavares commented Mar 31, 2022

…n name

Description of change

allow this logic to slowly make its way into the turbine libraries

Fixes https://github.com/meroxa/turbine-project/issues/125

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging

Demo

Screenshot from 2022-03-31 13-30-48

same logic applied to something easier to test HAH

Additional references

Documentation updated

@janelletavares janelletavares requested review from a team, ericcheatham and samirketema and removed request for a team March 31, 2022 20:30
Copy link
Contributor

@ericcheatham ericcheatham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janelletavares if the app was already created, we should double check before returning that the pipeline associated is the one that's intended, otherwise it'd seemed like it worked, when it shouldn't have.

I was thinking we could fetch for application before creating and then comparing pipeline uuid there (if it exists). This, only until each turbine language implements their own app creation.

What do you think?

@janelletavares
Copy link
Contributor Author

@janelletavares if the app was already created, we should double check before returning that the pipeline associated is the one that's intended, otherwise it'd seemed like it worked, when it shouldn't have.

I was thinking we could fetch for application before creating and then comparing pipeline uuid there (if it exists). This, only until each turbine language implements their own app creation.

What do you think?

double checking seems very reasonable. will whip that up.

@janelletavares
Copy link
Contributor Author

small meroxa-go change was needed https://github.com/meroxa/meroxa-go/pull/108/files

@janelletavares janelletavares merged commit 1636a89 into master Apr 4, 2022
@janelletavares janelletavares deleted the create-app-sometimes branch April 4, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants