Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include all pre-requisites for go app run in app init #288

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Include all pre-requisites for go app run in app init #288

merged 2 commits into from
Mar 29, 2022

Conversation

janelletavares
Copy link
Contributor

@janelletavares janelletavares commented Mar 25, 2022 •
edited
Loading

Description of change

Fixes https://github.com/meroxa/turbine-project/issues/92

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging
  • manual

Demo

Screenshot from 2022-03-28 15-19-15

Screenshot from 2022-03-28 15-17-49

Additional references

Documentation updated

updated turbine PR as well https://github.com/meroxa/turbine/pull/19

@janelletavares janelletavares requested review from a team, owenthereal and dianadoherty and removed request for a team March 25, 2022 18:18
@janelletavares janelletavares force-pushed the go-mod-init branch 2 times, most recently from e674aa5 to 94280ac Compare March 25, 2022 22:05
raulb
raulb approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a question on some fields for AppConfig. Otherwise looks good to me.

Glad to see this feature being added. Thank you @janelletavares !

cmd/meroxa/turbine_cli/utils.go Outdated Show resolved Hide resolved
cmd/meroxa/turbine_cli/utils.go Show resolved Hide resolved
@jayjayjpg jayjayjpg mentioned this pull request Mar 29, 2022
Merged
5 tasks
@janelletavares janelletavares merged commit 00e64fd into master Mar 29, 2022
@janelletavares janelletavares deleted the go-mod-init branch March 29, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb approved these changes

@owenthereal owenthereal Awaiting requested review from owenthereal owenthereal was automatically assigned from meroxa/platform-backend

@dianadoherty dianadoherty Awaiting requested review from dianadoherty dianadoherty was automatically assigned from meroxa/platform-backend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janelletavares @raulb