Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(turbine): Path should always be converted to absolute #284

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

janelletavares
Copy link
Contributor

@janelletavares janelletavares commented Mar 22, 2022

Description of change

Only the path flag on run was being interpreted as absolute, and not init or deploy.

Fixes https://github.com/meroxa/turbine-project/issues/99

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging
  • manual

Demo

Screenshot from 2022-03-22 14-07-33

Additional references

Documentation updated

@janelletavares janelletavares requested review from a team, samirketema and dianadoherty and removed request for a team March 22, 2022 21:06
@janelletavares janelletavares merged commit 9b2ca91 into master Mar 24, 2022
@janelletavares janelletavares deleted the fix-absolute-path-again branch March 24, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants