feat: Get image from platform #283
Conversation
raulb
force-pushed
the
raul/build-service-integration
branch
from
c76fd12
to
c796e80
Compare
| } | ||
|
|
||
| fmt.Print("Getting status for build: ", build.Uuid) | ||
| for { |
There was a problem hiding this comment.
seems dangerous to have no timeout, but i guess it's easy enough to shutdown the CLI
There was a problem hiding this comment.
@janelletavares that's right, you could still Ctrl+C if you have to. I could still add a time out though
janelletavares
force-pushed
the
raul/build-service-integration
branch
from
24018cd
to
af76250
Compare
|
i've rebased and updated the dependencies for this branch, as well as addressed lint issues. i feel like Deploy is now too complicated to do much more unit testing in a meaningful way without some potentially convoluted refactoring. i'd prefer to put developer efforts towards acceptance tests as this point. what do you think? |
|
@janelletavares agreed. Especially since we still need to combine this part to be even more generic so each language does less. Ship it? |
|
|
||
| fmt.Print("Getting status for build: ", build.Uuid) | ||
| for { | ||
| fmt.Printf(".") |
There was a problem hiding this comment.
are we using print instead of log because of the newlines here?
There was a problem hiding this comment.
@janelletavares that's right. I think that should improved though. We'll improve this once we work on https://github.com/meroxa/turbine-project/issues/86.
raulb
force-pushed
the
raul/build-service-integration
branch
from
e8c3758
to
c60ea46
Compare
raulb
force-pushed
the
raul/build-service-integration
branch
from
25d854b
to
d2929ab
Compare
Description of change
Fixes https://github.com/meroxa/turbine-project/issues/45
Depends on https://github.com/meroxa/meroxa-go/pull/106Type of change
How was this tested?
Demo
See Slack.