-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(turbine): Warn about uncommitted changes #275
Conversation
I commented out most of the deploy command to test this |
61040fb
to
62601dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of required changes so we stop the execution of the deployment once we have untracked changes.
Aside, I'd like to make the suggestion of simplifying this a bit. What I think could be simpler is:
- Run
cmd := exec.Command("git", "status", "--porcelain=v2")
- If there are untracked changes, then run
git status
and show the output to the user including a custom message indicating that need to commit first. - If everything is tracked continue.
What do you think? @janelletavares
I'm made another pass based on these comments. Are we checking branch somewhere else? I forget. Or should we open another ticket for that check? It would be easy to add it to this PR if it's relevant enough. jk... it's started here https://github.com/meroxa/cli/pull/276/files#diff-9660bb3708bfbd2d8adc60d0b68dfd003cbf13421ea4212747439a8c11fc54b5R140 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
4aa170c
to
f299672
Compare
Description of change
Fixes https://github.com/meroxa/turbine-project/issues/70
Type of change
How was this tested?
Demo
Additional references
Documentation updated