feat(repair): allow users to repair environments #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayjayjpg
force-pushed
the
jj/save-the-environment
branch
3 times, most recently
from
67e244f
to
8c09954
Compare
jayjayjpg
force-pushed
the
jj/save-the-environment
branch
from
8c09954
to
b26961d
Compare
dianadoherty
reviewed
Feb 2, 2022
| } | ||
|
|
||
| func (r *Repair) Execute(ctx context.Context) error { | ||
| rr, err := r.client.PerformActionOnEnvironment(ctx, r.args.NameOrUUID, &meroxa.RepairEnvironmentInput{Action: "repair"}) |
There was a problem hiding this comment.
Suggested change
| rr, err := r.client.PerformActionOnEnvironment(ctx, r.args.NameOrUUID, &meroxa.RepairEnvironmentInput{Action: "repair"}) | |
| rr, err := r.client.PerformActionOnEnvironment(ctx, r.args.NameOrUUID, &meroxa.RepairEnvironmentInput{Action: meroxa. EnvironmentActionRepair}) |
There was a problem hiding this comment.
Great catch and I updated this accordingly!
…ommand Co-authored-by: Diana Doherty <[email protected]>
jayjayjpg
force-pushed
the
jj/save-the-environment
branch
from
e0a54e9
to
9acaa71
Compare
Co-authored by Diana Doherty <[email protected]>
jayjayjpg
force-pushed
the
jj/save-the-environment
branch
from
d7c0194
to
a69cdfe
Compare
dianadoherty
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Closes #184
This adds the
meroxa environment repaircommand to the CLI.Type of change
How was this tested?
Demo
Staging
|
|
Locally
Blockers
Additional references
Related to https://github.com/meroxa/platform-api/pull/811
Related to https://github.com/meroxa/meroxa-go/pull/92
Environment Implementation Plan (CLI): https://www.notion.so/meroxa/Environment-Implementation-Plan-Stage-2-60970cbce0a44c2b9095c0fea4172a69#7bc7dded7ae44b4e9fcd6e27ad189bba
Environment Implementation Plan (Client-API): https://www.notion.so/meroxa/Environment-Implementation-Plan-Stage-2-60970cbce0a44c2b9095c0fea4172a69#261d954133834d088323bfa6867375c1
Documentation updated
Since the feature is still hidden, this change does not include any doc updates.